Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for overzealous reserved-character checking in hyperlink #119

Merged
merged 1 commit into from
Jun 25, 2017

Conversation

glyph
Copy link
Member

@glyph glyph commented Jun 25, 2017

hopefully this is temporary just until python-hyper/hyperlink#16 is resolved.


This change is Reviewable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
hopefully this is temporary just until
python-hyper/hyperlink#16 is resolved.
@glyph
Copy link
Member Author

glyph commented Jun 25, 2017

I just wanted to fix #118. This yak stack is getting a bit deep for my taste.

@codecov
Copy link

codecov bot commented Jun 25, 2017

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines        1987   1987           
  Branches      174    174           
=====================================
  Hits         1987   1987
Impacted Files Coverage Δ
src/txacme/test/strategies.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69dd453...08d6d7a. Read the comment docs.

@glyph
Copy link
Member Author

glyph commented Jun 25, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@glyph
Copy link
Member Author

glyph commented Jun 25, 2017

Since current master is already failing, I'm going to unilaterally merge this fix for now. I would be interested in any post-hoc commentary if this is the wrong way to generate URLs for these tests.

@glyph glyph merged commit ba85d21 into master Jun 25, 2017
@glyph glyph deleted the tests-pass-please branch June 25, 2017 09:23
@mithrandi
Copy link
Contributor

This seems fine to me; currently there's only a few places this strategy is used, and none of them do anything particularly interesting with the URL, so I don't think we need to worry about lack of coverage of obscure escaping cases or whatever, at least not for our own benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants