Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make RotatedRect and TermCriteria cross module dependencies #21

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

BenTheElder
Copy link
Contributor

@BenTheElder BenTheElder commented Jun 1, 2016

This makes RotatedRect and TermCriteria cross module dependencies, enabling some more methods.
Also manual rename for conflict introduced in BOWKMeansTrainer constructors.

This enables some more methods I was looking for (video::cam_shift and video::mean_shift).

@BenTheElder
Copy link
Contributor Author

I'm unsure of the manual rename for BOWKMeansTrainer, a better name might be in order.

Also, I would still like to get calcHist and calcBackProject working (for use with CamShift), they seem to require some unsupported features in the generator ("returning primitive by pointer is not supported (FIXME ?)"), what would it take to fix this?

Oh and by the way: I ran into a bug on rust 1.9.0 and nightly that causes the documentation to fail to build because rustdoc tries to build files for the long sys:: methods that should be hidden, I'm working around this by using 1.8.0 locally, but I am looking into getting this fixed.
Previous discussion: reddit, rust issue.

And lastly: Thanks for the awesome work on this project!

@BenTheElder BenTheElder changed the title make RotatedRect and TermCriteria cross module depdencies make RotatedRect and TermCriteria cross module dependencies Jun 1, 2016
also manual rename for conflict introduced in BOWKMeansTrainer constructors
@kali
Copy link
Contributor

kali commented Jun 2, 2016

Thanks for your interest in this nightmarishly ugly thing :)

About BOWKMeansTrainer, I have really no idea how we should call them. I don't use at all this part of OpenCV, I barely know what is is about. So if you feel like it should be changed, feel free. I'm not worrying too much about breaking dependent code at this stage.

I think fixing the primitive by pointer should be quite straightforward. The pattern was just not used in the subset I needed... I have little time to do it, but feel fry to give it a try and tell me how it goes.

Do you need a release with this PR merged or should I wait for more ?

@kali kali merged commit cad7165 into twistedfall:master Jun 2, 2016
@BenTheElder
Copy link
Contributor Author

Thanks!

I will look at enabling some more methods soon, I'd like to finish getting
motion tracking with CamShift working :)
On Jun 2, 2016 03:58, "Mathieu Poumeyrol" notifications@github.com wrote:

Merged #21 #21.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#21 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA4Bq-Wu78-WoPa9-D92bG3jURc6s5_tks5qHo0mgaJpZM4Ir7Aw
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants