Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename named modules to mod.rs #157

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Rename named modules to mod.rs #157

merged 4 commits into from
Jun 9, 2021

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jun 9, 2021 •
edited
Loading

This also fixes some issues with clippy and nightly rust

@Emilgardis
Rename named modules to mod.rs
9ad335e 
refactor to a more "modern" ™️ way to do modules
there was no real benefit to having named mod.rs files. This fixes that
@Emilgardis Emilgardis force-pushed the renames branch 3 times, most recently from 79ffb0e to bcdacc0 Compare June 9, 2021 19:15
@Emilgardis
Copy link
Member Author

I'm pretty sure the cfg attr should prevent this error

error[E0658]: arbitrary expressions in key-value attributes are unstable
Error:   --> src/lib.rs:93:58
   |
93 | #[cfg_attr(all(doctest, nightly, feature = "all"), doc = include_str!("../README.md"))]
   |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #78835 <rust-lang/rust/issues/78835> for more information

error[E0658]: arbitrary expressions in key-value attributes are unstable
Error:   --> src/lib.rs:93:58
   |
93 | #[cfg_attr(all(doctest, nightly, feature = "all"), doc = include_str!("../README.md"))]
   |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #78835 <rust-lang/rust/issues/78835> for more information

will have to ugly-hack it

@Emilgardis
Copy link
Member Author

rust-lang/rust#82768

very nice :)

@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 9, 2021

Build succeeded:

@bors bors bot merged commit 7aefad9 into master Jun 9, 2021
@bors bors bot deleted the renames branch June 9, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Emilgardis