Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary sprintf #287

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix: remove unnecessary sprintf #287

merged 3 commits into from
Nov 3, 2023

Conversation

SputNikPlop
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Error: unnecessary use of fmt.Sprintf (S1039)

Description of Changes:

  • Fixed the issue by removing the unnecessary use

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

Xemdo
Xemdo requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Xemdo Xemdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the unnecessary variable

internal/events/trigger/trigger_event.go Outdated Show resolved Hide resolved
@SputNikPlop SputNikPlop requested a review from Xemdo November 3, 2023 02:31
@Xemdo Xemdo merged commit bf51f4f into twitchdev:main Nov 3, 2023
4 checks passed
@SputNikPlop SputNikPlop deleted the sprintf branch November 3, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xemdo Xemdo Xemdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SputNikPlop @Xemdo