Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proto3 field presence #332

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Commits on Aug 23, 2021

  1. Support proto3 field presence

    Protobuf recently added support for [optional fields][].
    These are opt-in on a per-code-generator basis.
    Without this flag, you get an error:
    
        example.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-twirp hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.
    
    As far as I can tell, there should not be anything special we need to do
    to support optional fields in Twirp as we only reference message types
    and don't do anything with their fields.
    
    [optional fields]: https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#application-note-field-presence
    mterwill committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    a973182 View commit details
    Browse the repository at this point in the history