Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Cleanup spitball errors #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Cleanup spitball errors #9

wants to merge 8 commits into from

Conversation

chadrosen
Copy link

The most annoying thing with spitball are the errors that are returned when there is a problem parsing the gemfile or gemfile.lock. The server ends up returning a ton of HTML which makes it almost impossible to debug. I've tried to make this better by raise specific errors when parsing gemfiles, catching them in the server code, and returning them in a nicer way to the client.

In an effort to make debugging easier I've also added a html dashboard on the / route that lets you upload from the web instead of the client.

@ramen
Copy link

ramen commented Jun 2, 2014

Oh, I thought it was a typo from using too much Vim. :) Only suggestion would be to change it to something like "SYNTAXERROR" to make it more obvious what's going on.

@giladbu
Copy link

giladbu commented Jun 2, 2014

+1

@bigloser
Copy link
Contributor

bigloser commented Jun 7, 2014

Sorry for the delay, but looks good to me, resolve conflicts and I'll merge and upload.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chad Rosen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants