Skip to content
This repository has been archived by the owner on Oct 5, 2019. It is now read-only.

FIX : Return YES if the SSO login isMobileSSOSuccess #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leverdeterre
Copy link

Problem

I was not able to properly finalize a login with a Twitter account using Firebase. The Twitter login is actually impossible to enable with the FirebaseUI auth providers.
I noticed an error in your management of OpenUrl in the application delegate

Solution

Say YES when TwitterKit is challenged to open an URL and the SSO is a success. TwitterKit has done the job!

Result

Avoid a crash on the providers loop on the Firebase UI SDK because the SDK will try to find a provider to handle the asked openUrl and your SDK has complete the job 👍

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jérôme Morissard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ducnv2910
Copy link

Please merge it soon. because it doesn't work on swift 4.2

@NathanWalker
Copy link

Hi @leverdeterre would you mind sharing how you built this locally? Having trouble building directly from your repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants