Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

link @ in @name #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

link @ in @name #125

wants to merge 4 commits into from

Conversation

jakl
Copy link
Contributor

@jakl jakl commented May 19, 2014

@KL-7 or @jugyo could you review? Whenever you have time.
INTL-5848

@jakl
Copy link
Contributor Author

jakl commented May 19, 2014

I'll push the latest conformance submodule to make Travis CI succeed.

@jakl
Copy link
Contributor Author

jakl commented May 19, 2014

Looks like the git submodule command isn't compatible with git@... url's. I'll revert that.
It is highly convenient locally for committing edits in a submodule - too bad...

@KL-7
Copy link
Contributor

KL-7 commented May 19, 2014

:shipit:

@jakl
Copy link
Contributor Author

jakl commented May 19, 2014

Thanks! I might have another minor change here - then I'll update Java, Ruby, Objc, Conformance - then shipit and publish. 8)

@timhaines
Copy link

@jakl Nice work. Is the other minor change fixing the tweet character botching? #122

@jugyo
Copy link
Contributor

jugyo commented May 20, 2014

Good job :)

@thiagogds
Copy link

👍

@rodrigopinto
Copy link

👍 Any idea when it would be merged?

@kush-patel-hs
Copy link

👍 please merge

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants