Support pending targets in linting #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A target is said to be pending if its BUILD file has a sibling named
`PENDING`. When linting, pending targets that have conflicting
dependencies will report a warning instead of an error. Linting will
succeed if only pending targets report dependency conflicts.
The YAML report format is changed to:
```
"//my/target:name" {"failure": <true or false>, "conflicts": {"org:name": ["1.0", "2.0"], ...}}
```
The `failure` field is always false for pending targets.
eed3si9n
reviewed
Jan 7, 2021
eed3si9n
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A target is said to be pending if its BUILD file has a sibling named
PENDING. When linting, pending targets that have conflictingdependencies will report a warning instead of an error. Linting will
succeed if only pending targets report dependency conflicts.
The YAML report format is changed to:
The
failurefield is always false for pending targets.