Persist classifier and improve version comparison #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref coursier/versions#10 `compat.isCompatible(...)` doesn't work when the version number includes weird alphabet tags in there like `3.10.1.Final`. This tries to work round the issue by calculating the minimum compatible versions and comparing the two.
eed3si9n
force-pushed
the
wip/netty-jetty
branch
from
8361c9c to
1836307
Compare
eed3si9n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref coursier/versions#10
compat.isCompatible(...)doesn't work when the version number includesweird alphabet tags in there like
3.10.1.Final.This tries to work round the issue by calculating the minimum compatible
versions and comparing the two.