Stats to file #186
Merged
Stats to file #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 14, 2019 17:51
This reverts commit 286eece.
fakeNetflix
pushed a commit
to fakeNetflix/twitter-repo-ccommon
that referenced
this pull request
Aug 18, 2019
* Backport changes from pelikan to twitter/ccommon#186 * Missed a few files for rust support
fakeNetflix
pushed a commit
to fakeNetflix/twitter-repo-ccommon
that referenced
this pull request
Aug 18, 2019
Backport changes from pelikan to twitter/ccommon#186 Implement proper allocation/free for BString objects * All allocation of BStrings should happen from libc malloc() that way we don't mistakenly free something allocated from rust's allocator. * Drop should call libc's free() with the pointer, doing the correct thing. * This philosophy allows us to pass bstring pointers back and forth and not have to track which heap they're allocated on * Provide an implementation of a zero-cost reference object, much like String -> &str, we have BString -> &BStr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current stats is purely pull-based. Without external observability harness, there's no easy way of getting/preserving historical readings on application level metrics.
Solution
Providing a few functions that allow a log file to be used to store metrics as a CSV. Caller will need to setup timer to actually kick off the stats logging, such as by scheduling recurring events using timing wheel.
Result
Intend to use this in Pelikan_twemcache to facilitate the load testing that's under way.