Update scala-library to 2.12.14

[scala-steward]

Updates org.scala-lang:scala-library from 2.12.12 to 2.12.14.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.12.12).
You might want to review and update them manually.

.github/workflows/ci.yaml

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

labels: library-update, semver-patch, old-version-remains

[codecov-commenter]

Codecov Report

Merging #562 (1aa7d18) into develop (9b19e3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #562   +/-   ##
========================================
  Coverage    91.69%   91.69%           
========================================
  Files           42       42           
  Lines         1397     1397           
  Branches        36       36           
========================================
  Hits          1281     1281           
  Misses         116      116           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b19e3a...1aa7d18. Read the comment docs.

[regadas]

WrappedArrayBuilder in 2.12.13+ suffered some updates (still need look into more detail) and as a consequence, the WrappedArray round trip serde is broken; From a quick look, it seems that the result array from WrappedArrayBuilder is losing its class.

I wonder why we are using the WrappedArrayBuilder which has an underlying array copy instead of just WrappedArray.make; With the latter, serde roundtrip is ok.

@johnynek I'm hoping you can shed some light, I might be missing something, do you remember?

chill/chill-scala/src/main/scala-2.12-/com/twitter/chill/WrappedArraySerializer.scala

Lines 34 to 39 in e067ea8

	val clazz = kser.readObject(in, classOf[Class[T]])
	val array = kser.readClassAndObject(in).asInstanceOf[Array[T]]
	val bldr = new WrappedArrayBuilder[T](ClassTag[T](clazz))
	bldr.sizeHint(array.size)
	bldr ++= array
	bldr.result()

[johnynek]

I'm pretty ready to give up on the idea that serialized data is stable.

The use of this library is for runtime ad-hoc serialization between processes (think: akka, hadoop, spark, storm, etc...)

It's not for archival storage. That's a much harder problem.

What do you think @regadas ?

[regadas]

@johnynek I'm totally on board with that! based on your previous suggestion (older PR's) I added a section to the README. https://github.com/twitter/chill#compatibility let me know if it needs some work.

[johnynek]

sounds good!

Let's go nuts...

As long as CI passes. :)

We probably should work to make it easier to test serializers with scalacheck and get our coverage up high.