Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finagle-opencensus-tracing: -> 2.13 #822

Closed
wants to merge 1 commit into from

Conversation

hderms
Copy link
Contributor

@hderms hderms commented Jan 2, 2020

Problem

No cross-build for finagle-opencensus-tracing 2.13

Solution

include 2.13 in finagle-opencensus-tracing cross versions.

@hderms hderms mentioned this pull request Jan 2, 2020
28 tasks
@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #822 into develop will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #822      +/-   ##
===========================================
+ Coverage    71.94%   73.01%   +1.06%     
===========================================
  Files          866      866              
  Lines        25184    25184              
  Branches      1823     1799      -24     
===========================================
+ Hits         18119    18387     +268     
+ Misses        7065     6797     -268
Impacted Files Coverage Δ
...twitter/finagle/service/PendingRequestFilter.scala 86.36% <0%> (-4.55%) ⬇️
...r/finagle/dispatch/GenSerialClientDispatcher.scala 77.77% <0%> (-3.71%) ⬇️
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala 88.57% <0%> (-2.86%) ⬇️
...rtitioning/ConsistentHashPartitioningService.scala 88.63% <0%> (-2.28%) ⬇️
...tter/finagle/redis/protocol/commands/Streams.scala 97.5% <0%> (-1.25%) ⬇️
.../http/exp/GenStreamingSerialServerDispatcher.scala 77.08% <0%> (+6.25%) ⬆️
...gle/http2/transport/client/ClientServiceImpl.scala 90.9% <0%> (+9.09%) ⬆️
...gle/http2/transport/client/ClientSessionImpl.scala 90.9% <0%> (+11.36%) ⬆️
.../main/scala/com/twitter/finagle/mux/Response.scala 57.14% <0%> (+14.28%) ⬆️
...ter/finagle/zipkin/thrift/ScribeZipkinTracer.scala 41.66% <0%> (+41.66%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1de8cb...a171a12. Read the comment docs.

@yufangong
Copy link
Contributor

This is merged fee83b1. Thanks for the patch!

@yufangong yufangong closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants