ability to specify minModificationTimeMillis as arg#107
ability to specify minModificationTimeMillis as arg#107angadsingh wants to merge 1 commit intotwitter:masterfrom
Conversation
| // Start of this time period is the end of the last period. | ||
| minModificationTimeMillis = lastProcessRecord | ||
| .getMaxModificationTimeMillis(); | ||
| LOG.info("lastProcessRecord time: " + lastProcessRecord.getMaxModificationTimeMillis()); |
There was a problem hiding this comment.
A minor improvement suggestion -maybe have a variable that stores the lastProcessRecord.getMaxModificationTimeMillis() since it is being called thrice in this code block?
|
Overall, this pull request looks good to me (except for the minor improvement suggestion) |
| // Accept a minModificationTimeMillis. Don't process files before this time. | ||
| o = new Option("m", "minModificationTimeMillis", true, | ||
| "The minimum modification time of the file to be processed"); | ||
| o.setArgName("minModificationTimeMillis"); |
There was a problem hiding this comment.
Is millis the most user-friendly, least error prone way to get this argument ?
Wouldn;t it be better to get something in a more huma-readable form ?
Perhaps yyyymmddhhMMss or something like that ?
There was a problem hiding this comment.
I actually think having a timestamp (long number) in epoch milliseconds is cleaner than a yyyymmdd etc format.
|
Angad Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
4 participants
as an argument to JobFilePreProcessor. Only files after this timestamp will be picked up. Still honor lastProcessRecord.