forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In fb30d2d if isinstance(cause, UnreadableArtifact): return (target_address, cause.err.message) However, `exception.message` isn't always a string, it's `args[0]` whatever is passed as first argument [1], maybe string, maybe another wrapped exception. This results a later error when called by json.dump [2] Further, `exception.message` is deprecated in python 3 [1], this PR drops such usages [1] https://www.python.org/dev/peps/pep-0352 [2] bug stacktrace File "/Users/peiyu/.pex/install/pantsbuild.pants-0.0.0_fb30d2db66b95d2bb602cbaae60037c18d2710b6-py2-none-any.whl.5632d5cbfcdd1b48dcdcbd328644dfab1f356c58/pantsbuild.pants-0.0.0_fb30d2db66b95d2bb602cbaae60037c18d2710b6-py2-none-any.whl/pants/goal/run_tracker.py", line 263, in store_stats safe_file_dump(stats_file, json.dumps(stats)) ... Exception message: ConnectionError(ProtocolError('Connection aborted.', gaierror(8, 'nodename nor servnam Testing Done: https://travis-ci.org/pantsbuild/pants/builds/94495459 Bugs closed: 2656 Reviewed at https://rbcommons.com/s/twitter/r/3201/
- Loading branch information
Showing
4 changed files
with
12 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters