rename the redis binaries to ds (dataserver) #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2018 18:13
|
i am fine with this for now, but as we finalize the protocol we may want to think of a less generic name than "dataserver" |
This comment was marked as spam.
This comment was marked as spam.
swlynch99
pushed a commit
to swlynch99/pelikan-twitter
that referenced
this pull request
Sep 30, 2019
- Ref twitter#202, twitter/pelikan@14fcd34 - Replace CHECK_WORKING with CHECK_FOUND - call make test instead of make check - Fix Cmake warning "Policy CMP0075" by remove CMAKE_REQUIRED_LIBRARIES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started introducing different APIs based on the RESP so these should not be called Redis to avoid confusion.
This is the first of the two PRs needed for the clean-up, which only affects the code under
src/server.The changes under
src/protocolis more involved, because we are essentially introducing two sets of APIs that share the same wire protocol. I need to think about how to minimize duplicate code while allowing both to be compiled simultaneously (which may or may not be feasible when implemented in C).