Change hash function in GroupRandomly #1401
Merged
ianoc merged 4 commits intotwitter:developfrom Aug 4, 2015
Merged
Conversation
Contributor
|
This goes better in the TypedPipe object? |
Author
|
I guess I can move it there and make it private. I inlined it because I dont want anyone using it outside this method |
Contributor
|
Looks good to me |
Collaborator
There was a problem hiding this comment.
can we use this for .shard now?
Collaborator
|
LGTM, thanks for getting on this quickly |
ianoc
added a commit
that referenced
this pull request
Aug 4, 2015
Change hash function in GroupRandomly
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current hashing is causing collision so switching to identity hash.