Adds a function to test if a sink exists at the version we created#1404
Merged
Gabriella439 merged 1 commit intodevelopfrom Aug 4, 2015
Merged
Adds a function to test if a sink exists at the version we created#1404Gabriella439 merged 1 commit intodevelopfrom
Gabriella439 merged 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Maybe use a Try/Maybe instead of throwing an error. How likely is it that there will be a mode other than those three?
Collaborator
Author
There was a problem hiding this comment.
Extremely unlikely, the other methods in this class seem to just cast under the wildcard case
Collaborator
There was a problem hiding this comment.
Yeah, there is little type safety around Mode, and no way to recover from a bad mode, so I'd leave it as is (Mode is generally configured at runtime).
Gabriella439
added a commit
that referenced
this pull request
Aug 4, 2015
…hStatus Adds a function to test if a sink exists at the version we created
Collaborator
There was a problem hiding this comment.
we should have return types on public methods.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In summingbird would like to not try write into a version if it already exists