add .groupWith method to TypedPipe#1406
Merged
johnynek merged 1 commit intotwitter:developfrom Aug 5, 2015
Merged
Conversation
This method is more convenient than trying to pass the Ordering[K] explicitly into the .group method because there is no need to also specify the evidence parameter proving that the TypedPipe[T] is a TypedPipe[(K, V)].
Collaborator
|
is it worth it over doing .group(implicitly, myordering) ? |
Contributor
Author
|
The use of |
johnynek
added a commit
that referenced
this pull request
Aug 5, 2015
add .groupWith method to TypedPipe
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is more convenient than trying to pass the
Ordering[K]explicitly into the.groupmethod because there is no need to also specify the evidence parameter proving that theTypedPipe[T]is aTypedPipe[(K, V)].