add counter verification logic#1409
Merged
johnynek merged 1 commit intotwitter:developfrom Aug 7, 2015
nevillelyh:neville/counters
Merged
add counter verification logic#1409johnynek merged 1 commit intotwitter:developfrom nevillelyh:neville/counters
johnynek merged 1 commit intotwitter:developfrom
nevillelyh:neville/counters
Conversation
Contributor
There was a problem hiding this comment.
This needs to check for TestMode along with the flag here, right? and always add StatsFlowListener in other modes.
Contributor
Author
There was a problem hiding this comment.
Good catch. Forgot to port this from our internal fork.
johnynek
added a commit
that referenced
this pull request
Aug 7, 2015
add counter verification logic
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow users to mix in a
CounterVerificationtrait and implement their ownverifyCountersmethod when the job completes. We use this to fail jobs that produced invalid data, e.g. too many nulls or incorrect distribution.