Don't squash the exception in history service when there's a failure#1434
Merged
isnotinvain merged 1 commit intodevelopfrom Sep 3, 2015
Merged
Don't squash the exception in history service when there's a failure#1434isnotinvain merged 1 commit intodevelopfrom
isnotinvain merged 1 commit intodevelopfrom
Conversation
Contributor
|
LGTM |
isnotinvain
added a commit
that referenced
this pull request
Sep 3, 2015
Don't squash the exception in history service when there's a failure
ulyssepence
pushed a commit
that referenced
this pull request
Sep 3, 2015
Sibling PR to #1434. We should log the exception so we know why this failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exception's .toString only gives you the message, passing the exception to the logger will surface the nested errors as well which is what you care about in this case.