Skip to content

No Source validation when running in TestMode#1443

Closed
MansurAshraf wants to merge 1 commit intotwitter:developfrom
MansurAshraf:mashraf/no_validation_in_test
Closed

No Source validation when running in TestMode#1443
MansurAshraf wants to merge 1 commit intotwitter:developfrom
MansurAshraf:mashraf/no_validation_in_test

Conversation

@MansurAshraf
Copy link

No Source validation when running in TestMode. #1441 broke bunch of tests internally.

@MansurAshraf
Copy link
Author

running internal integration suits, dont merge

@Gabriella439
Copy link
Contributor

Is this safe to disable? I don't know a whole lot about the tests, but I want to make sure that this isn't disabling validations that other tests are using to detect regressions

@Gabriella439
Copy link
Contributor

It also seems like a really weird corner case. If we do include this as a temporary fix there needs to be an explanatory comment explaining why it's there and what work needs to be done to remove it. Otherwise somebody with no context won't know if it's safe to tamper with that.

@MansurAshraf
Copy link
Author

@Gabriel439 this was the exact behavior before #1441 got merged. As in we were not calling Validate in JobTEst

@Gabriella439
Copy link
Contributor

Alright. There should still probably be a comment explaining why these specific test validations are being blacklisted

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@johnynek johnynek closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments