Fix bug with sketch joins and single keys#1451
Merged
isnotinvain merged 2 commits intodevelopfrom Nov 4, 2015
Merged
Conversation
Collaborator
Author
|
@isnotinvain can you review? |
Contributor
|
LGTM, FWIW. |
Contributor
There was a problem hiding this comment.
I don't understand this explanation of the test. What is this testing?
Collaborator
Author
There was a problem hiding this comment.
I didn't edit it properly. There was originally a normal join and a sketch join in the job, but I removed the normal join since it was just easier to assert the output was a particular thing. This particular input and output caused an exception before, so the fact that it is green now is a guard against a particular regression, but the message is not good. I'll update it.
isnotinvain
added a commit
that referenced
this pull request
Nov 4, 2015
Fix bug with sketch joins and single keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue in #1218 and #1449 based on the contribution in #1450
The fix requires a minor change to the API, which should be source compatible for virtually everyone.
It also exposes two design flaws in algebird: 1) that we assume == works, so having a CMSHasher on Arrays is broken. 2) implicits for CMSHasher are not in the companion object, so they are annoying to use.