Add OrderedSerialization2 support in Matrix2.

[reconditesea]

To resolve issue #1418

[reconditesea]

@johnynek Is this good to go?

[johnynek]

Sorry. Didn't see this. Thanks for bringing to my attention. I'll review
Monday.

On Saturday, December 19, 2015, Kevin Lin notifications@github.com wrote:

@johnynek https://github.com/johnynek Is this good to go?

—
Reply to this email directly or view it on GitHub
#1457 (comment).

P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin

[reconditesea]

Thanks, happy holidays!

[johnynek]

can you remove TDsl while you are at it?

[johnynek]

Need a test for this that some Matrix2 job works with the option: https://github.com/twitter/scalding/blob/develop/scalding-core/src/main/scala/com/twitter/scalding/Config.scala#L118 setRequiredOrderedSerialization(true).

In fact, we should write the test first and find an example that fails (I guess adding two matrices)

[reconditesea]

Moved the method implementation into OrderedSerialization2 companion object.
Will add new test cases shortly.

[reconditesea]

I had troubles in importing serialization test's intOrderedSerialization (

scalding/scalding-serialization/src/test/scala/com/twitter/scalding/serialization/SerializationProperties.scala

Line 46 in 3985459

implicit val intOrderedSerialization: OrderedSerialization[Int] = new OrderedSerialization[Int] {

) into Matrix2 test, so pasted the code into Matrix2 test.

BTW, feel like we can use slack channel for discussions like this more frequently.

[johnynek]

this style is not recommended any more (.toTypedPipe), so let's just use TypedText.tsv the whole way:

val tp1 = TypedPipe.from(TypedText.tsv[(Int, Int, Double)]("mat1"))