Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
I think reducer_estimation package object should be in com.twitter.scalding package.
http://www.scala-lang.org/docu/files/packageobjects/packageobjects.html
http://docs.scala-lang.org/style/naming-conventions.html#packages
Collaborator
There was a problem hiding this comment.
Yes, but I wonder why the compile didn't fail before. Ahh, because it was a root package. :/ Good catch.
Collaborator
|
Thanks for the cleanup. This looks good. |
Contributor
Author
|
It's my pleasure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirmed the past change,
539fcce#diff-cce8f848668405e685fa11b989199fb6R98
3bd578c#diff-cce8f848668405e685fa11b989199fb6L98
but I couldn't make sense whether reasonable that
MedianEstimationScheme.estimateJobTime(times)returnsmean(times)...Should this return
median(times)?