Adds Error Message to REPL when Current Directory Not Readable#1468
Merged
ianoc merged 2 commits intotwitter:developfrom Jan 8, 2016
Merged
Adds Error Message to REPL when Current Directory Not Readable#1468ianoc merged 2 commits intotwitter:developfrom
ianoc merged 2 commits intotwitter:developfrom
Conversation
Collaborator
|
merge when green |
ianoc
added a commit
that referenced
this pull request
Jan 8, 2016
Adds Error Message to REPL when Current Directory Not Readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, if the current directory is not readable,
new File(currentDirectory).listFiles()will lead to aNullPointerExceptioninfindAllUpPath. This patch adds a better error message.Alternatively, I could be persuaded to return an empty
Listinstead of throwing aRuntimeExceptionfromfindAllUpPathbecause I'm not aware of any contract that says you have to run thehadoopcommand from a readable directory.