Limit task history fields consumed from hraven

[rubanm]

Some jobs internally have been running into http content limits set by hraven. We really only need a few of the task history fields that are currently being consumed.

This change uses the new response filters added in hraven client to limit the amount of data being read:
https://github.com/twitter/hraven/blob/master/hraven-core/src/main/java/com/twitter/hraven/rest/client/HRavenRestClient.java#L356

[ianoc]

Is t05 a public release?

[rubanm]

Yep it's on maven central and sonatype
https://oss.sonatype.org/content/repositories/releases/com/twitter/hraven/hraven-core/

[ianoc]

Could you talk about if we will loose compatibility with older versions of hraven or if its a fall back. Have we manually tested this in real jobs?

(Does anyone outside twitter even use hraven?)

[rubanm]

We will lose compatibility with older versions. The newer version is already deployed internally at twitter. I've run a test cron job to verify hraven history gets picked up correctly. cc @vrushalivc

I'm not aware of anyone outside of twitter using the hraven estimators, so we're probably fine here.

[johnynek]

can this be factored out to a method call? The line is super long.

[johnynek]

This means a version bump if we are strict (not sure we should be for a submodule that maybe no one uses).

[rubanm]

Refactored the long line. Not bumping the version for now (we'll need to go from 0.15 to 0.16 to be strict?).

[ianoc]

@johnynek We sort of have been on RC's for too long around 0.16 i guess anyway. But thoughts in general about the backwards incomaptible for external users here. I'm not sure it really matters since I doubt anyone external to twitter uses this. I'd almost be inclined to say in future this is penciled for something that could just go back internal to twitter and not be in the OSS project

[johnynek]

Yeah, the specific Hraven calls should probably be internal to Twitter. LGTM otherwise.