Call validateTaps in toIterator codepath#1490
Merged
ianoc merged 2 commits intotwitter:developfrom Feb 2, 2016
Merged
Conversation
Merge from twitter/scalding
Collaborator
|
LGTM. others? |
Collaborator
|
LGTM also |
ianoc
added a commit
that referenced
this pull request
Feb 2, 2016
Call validateTaps in toIterator codepath
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1458 was meant to ensure we throw InvalidSourceException for all cases, but caused RuntimeException to be thrown in the toIterator codepath (instead of hadoop's InvalidInputException as was the case before that change). I looked into fixing it so that it throws InvalidSourceException.
As a more uniform solution though, I propose we call validateTaps in the toIterator codepath for all sources. Currently, toIterator can throw a few different exception types (hadoop's InvalidInputException, scalding' InvalidSourceException, RuntimeException) depending on whether we are in strict vs non strict mode, etc. This change will help ensure we throw scalding's InvalidSourceException for all cases.