More direct map and filter in typed API #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1742
We actually have map and filter implementations in the untyped cascading DSL of RichPipe, but somehow we never used them in the typed API.
This is a shame because for filter we were hiding them from cascading, and we were boxing all maps into single iterators, which we don't need to do. Lastly, the iteration in the FlatMapFunction we skip since in a map you know there is exactly one.
Finally, I think cascading reuses the tuple with a filter, so there is less allocation. This may also be possible with map, but I'm not 100% clear about it.