Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Memory platform using Dagon memoization #1836

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Mar 3, 2018

Using Dagon's Memoize.functionK, it is much easier to write recursive memoized functions without threading through the state yourself.

I changed the code here to do that since we will likely want to copy this approach in the spark backend (which I started to do in #1832 ).

@johnynek
Copy link
Collaborator Author

johnynek commented Mar 3, 2018

@non @erik-stripe can you review? you have the most dagon familiarity.

cc @ianoc @fwbrasil

@ianoc
Copy link
Collaborator

ianoc commented Mar 6, 2018

Erik's review would be better, but all looks pretty sane to me

@non
Copy link

non commented Mar 6, 2018

LGTM 👍

Not having to explicitly thread the memoization through really improves readability!

@johnynek johnynek merged commit abaaeb7 into develop Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants