Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove additional scmInfo injection #1999

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

daniel-sudz
Copy link
Contributor

closes #1998

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1999 (df850a2) into develop (a0516e0) will increase coverage by 15.95%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #1999       +/-   ##
==============================================
+ Coverage      17.98%   33.94%   +15.95%     
- Complexity       696     1175      +479     
==============================================
  Files            344      363       +19     
  Lines          26035    26694      +659     
  Branches        4506     4651      +145     
==============================================
+ Hits            4682     9060     +4378     
+ Misses         20520    16285     -4235     
- Partials         833     1349      +516     
Impacted Files Coverage Δ
...witter/scalding/typed/functions/FlatMappedFn.scala 41.81% <0.00%> (-1.82%) ⬇️
...alization/runtime_helpers/TraversableHelpers.scala 96.00% <0.00%> (-1.34%) ⬇️
...m/twitter/scalding/typed/functions/Functions.scala 12.04% <0.00%> (-1.21%) ⬇️
...com/twitter/scalding/typed/memory_backend/Op.scala 32.38% <0.00%> (-0.96%) ⬇️
...scala/com/twitter/scalding/hellcats/HellCats.scala 77.21% <0.00%> (ø)
...ng/db/macros/impl/handler/NumericTypeHandler.scala 0.00% <0.00%> (ø)
...src/main/scala/com/twitter/scalding/JsonLine.scala 72.97% <0.00%> (ø)
...tter/scalding/db/macros/impl/JdbcFieldSetter.scala 0.00% <0.00%> (ø)
...scalding/db/macros/impl/handler/ColumnFormat.scala 0.00% <0.00%> (ø)
.../scala/com/twitter/scalding/db/ColumnDefiner.scala 24.56% <0.00%> (ø)
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0516e0...df850a2. Read the comment docs.

@daniel-sudz
Copy link
Contributor Author

@johnynek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate tags in pom files
2 participants