Skip to content

Few Typo fixes #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Few Typo fixes #1539

wants to merge 2 commits into from

Conversation

vasanth-selvaraj
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Author

@vasanth-selvaraj vasanth-selvaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typos and spelling for the below files. Typos only fixed for the comments on the files

simclusters-ann/README.md
src/java/com/twitter/search/README.md
src/thrift/com/twitter/search/common/ranking/ranking.thrift
src/thrift/com/twitter/search/earlybird/thrift/earlybird.thrift
src/thrift/com/twitter/simclusters_v2/abuse.thrift
src/thrift/com/twitter/simclusters_v2/embedding.thrift
src/thrift/com/twitter/simclusters_v2/evaluation.thrift
src/thrift/com/twitter/simclusters_v2/identifier.thrift

@cynical-incendiary
Copy link

eww this PR should be closed as unconstructive contribution 🫨

Copy link
Author

@vasanth-selvaraj vasanth-selvaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the incorrect fix

@Imfaqngroovn
Copy link

You had me at the "sharded" typo.

Copy link

@aMiss-aWry aMiss-aWry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Rahul-Prasad-07 Rahul-Prasad-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants