-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Few Typo fixes #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few Typo fixes #1539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed typos and spelling for the below files. Typos only fixed for the comments on the files
simclusters-ann/README.md
src/java/com/twitter/search/README.md
src/thrift/com/twitter/search/common/ranking/ranking.thrift
src/thrift/com/twitter/search/earlybird/thrift/earlybird.thrift
src/thrift/com/twitter/simclusters_v2/abuse.thrift
src/thrift/com/twitter/simclusters_v2/embedding.thrift
src/thrift/com/twitter/simclusters_v2/evaluation.thrift
src/thrift/com/twitter/simclusters_v2/identifier.thrift
eww this PR should be closed as unconstructive contribution 🫨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the incorrect fix
You had me at the "sharded" typo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.