[JS] - When defaulting do not merge objects #276
Merged
+2,962
−147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we set the config version 3 as default we broke
v2
counting because we merge the passed in config with the default config. Now sinceemojiParsingEnabled
is a new field, when we merge objects with the default config, it is always enabledSolution
Don't merge configs. Only set to default it if we don't have anything in the config
Result
After the 3.0 release, v2 counting was broken. Now it will work again if it is explicitly passed.
Misc Changes: