Add twurl version to user agent header #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @andypiper This one is pretty straightforward I believe. Thanks! |
|
LGTM |
andypiper
approved these changes
Dec 8, 2019
|
@andypiper Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, twurl always uses
User-Agent: (OAuth gem v0.x.x)request header that comes from the oauth gem. For a better usage tracking/analytics purpose, we should consider adding a client's twurl, Ruby, and platform versions.Original PR was opened in #50 but since it's too old, I'm submitting a new PR for this. Also, with the original PR, it still remains
(OAuth gem v0.x.x)strings because of the oauth gem adds it on-the-fly. So I'm modifying it right after therequest.oauth!()call rather than adding it in the request controller.Example:
User-Agent: twurl version: 0.9.3 platform: ruby 2.6.1 (x86_64-darwin17)