Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch typeahead.css and set css properties through js #2

Closed
jharding opened this issue Feb 19, 2013 · 5 comments
Closed

Ditch typeahead.css and set css properties through js #2

jharding opened this issue Feb 19, 2013 · 5 comments
Assignees
Milestone

Comments

@jharding
Copy link
Contributor

Loading only typeahead.js > loading both typeahead.js and typeahead.css

@ghost ghost assigned jharding Feb 19, 2013
@seiz
Copy link

seiz commented Mar 12, 2013

I had to postpone usage of typeahead in my current project, because the typeahead styles messed too much with existing styles. For example, our searchfields will often have a non transparent background and some even an icon as background-image. Typeahead would reset the searchfield to have a transparent background and the transparent gif as background-image. This kind of destroys our layouts.

It'd be great if typeahead could work around IE bugs/behavior in a less destructive way, so it ultimately won't alter the appearance of input-fields attached to typeahead at all.

@jharding
Copy link
Contributor Author

Try the integration-0.9.0 branch, it has some changes that might solve your problem. If it doesn't work for you let me know, I'd like typeahead.js to work out of box for almost any use-case.

@seiz
Copy link

seiz commented Mar 12, 2013

Will do, thanks. First glimpse at the branch, it seem the transparent gif background etc. is gone, so this looks promising already. Thought the two commits attached to this ticket were from the 0.9 branch already and these still contained the gif... My bad.

@jharding
Copy link
Contributor Author

The transparent gif is still used for IE, but the background styles from the original input now get explicitly copied over to the hint input. I believe this will solve your problem.

@seiz
Copy link

seiz commented Mar 12, 2013

OK, so the input will be transparent and we'll see through the hint input which is a clone of the original input. That sounds good. I'll test this but it'll take a while as we're busy preparing/testing a release of our desktop-app (without typeahead for now, but to be included in the next release).
Thanks Jake!

jlbooker pushed a commit to jlbooker/typeahead.js that referenced this issue Jan 12, 2017
…bind

Use underscore bind instead of native.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants