asynchronous sources are rendered with the wrong limit #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the suggestions asynchronously, the number of returned items is set to the number of rendered items BEFORE creating the slice of the retrieved items that should be appended.
For example: limit is 5 and we returned exactly 5 items.
This would lead to rendered = 5 and the slice function gets 0, 0 as arguments and therefor, there won't be any suggestions appended.
Please see #1312 for more information and the discussion