Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asynchronous sources are rendered with the wrong limit #1316

Closed
wants to merge 2 commits into from
Closed

asynchronous sources are rendered with the wrong limit #1316

wants to merge 2 commits into from

Conversation

kr1x
Copy link

@kr1x kr1x commented Jul 9, 2015

When retrieving the suggestions asynchronously, the number of returned items is set to the number of rendered items BEFORE creating the slice of the retrieved items that should be appended.

For example: limit is 5 and we returned exactly 5 items.

rendered += suggestions.length;
that._append(query, suggestions.slice(0, that.limit - rendered));

This would lead to rendered = 5 and the slice function gets 0, 0 as arguments and therefor, there won't be any suggestions appended.

Please see #1312 for more information and the discussion

@dougaxe1 dougaxe1 mentioned this pull request Jul 31, 2015
@jlbooker
Copy link
Contributor

jlbooker commented Oct 5, 2015

Looks like a duplicate of #1212, has been fixed over at corejavascript/typeahead.js#8

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Christian Schuhbaum seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kr1x kr1x closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants