Skip to content

Commit

Permalink
Revert to scala 2.12.12 due to scoverage issue with scala 2.12.13
Browse files Browse the repository at this point in the history
Problem/Solution

The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13
(see: scoverage/sbt-scoverage#319). It has been patched in the
plugin in scoverage/scalac-scoverage-plugin#306 which is currently
awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken
and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been
published with the fix.

Differential Revision: https://phabricator.twitter.biz/D635917
  • Loading branch information
cacoco authored and jenkins committed Mar 17, 2021
1 parent 8b24447 commit c075bb1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
scala: [2.12.13, 2.13.1]
scala: [2.12.12, 2.13.1]
java: ['1.8', '1.11']
runs-on: ubuntu-latest
steps:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ Unreleased
Runtime Behavior Changes
~~~~~~~~~~~~~~~~~~~~~~~~

* util: Revert to scala version 2.12.12 due to https://github.com/scoverage/sbt-scoverage/issues/319
``PHAB_ID=D635917``

* util: Bump scala version to 2.12.13 ``PHAB_ID=D632567``

Breaking API Changes
Expand Down
4 changes: 2 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ def jdk11GcJavaOptions: Seq[String] = {
}

val defaultProjectSettings = Seq(
scalaVersion := "2.12.13",
crossScalaVersions := Seq("2.12.13", "2.13.1")
scalaVersion := "2.12.12",
crossScalaVersions := Seq("2.12.12", "2.13.1")
)

val baseSettings = Seq(
Expand Down

0 comments on commit c075bb1

Please sign in to comment.