Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala 2.13.1 to 2.13.6 #289

Closed
wants to merge 1 commit into from

Conversation

felixbr
Copy link
Contributor

@felixbr felixbr commented May 24, 2021

Problem

The latest Scala 2.13.x version is compatible with Scala 3.0.0 and includes many useful compiler-tools (e.g. warnings) to make the transition - and development in general - easier. Even if we don't have a real Scala 3 cross-build, 2.13.6 can be consumed by Scala 3 projects.

Solution

Updating Scala 2.13.1 to 2.13.6

Result

The build uses Scala 2.13.6. I also used the 2.13.x version as default as it has many extremely useful warnings that 2.12.x doesn't have. The only part that needed fixing is some reflection code as 2.13.5 changed encoding of method-parameter names.

As usual, I cannot tell if this clashes with any Twitter-internal things, so please tell me if it does.

@felixbr felixbr mentioned this pull request May 24, 2021
9 tasks
@mosesn
Copy link
Contributor

mosesn commented Jun 2, 2021

Great! Again, I don't think this will clash with anything, but let me double check.

@mosesn
Copy link
Contributor

mosesn commented Jun 10, 2021

Sorry for the delay, this was merged in a couple of days ago but I screwed up and merged in a bug with it too. Thanks again for the patch, and sorry again about the delay.

@mosesn mosesn closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants