Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scala 3 build for util-security #302

Closed
wants to merge 2 commits into from

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jun 22, 2022

relates to #274

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #302 (6e0e10f) into develop (9f15cce) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
+ Coverage    49.29%   49.31%   +0.01%     
===========================================
  Files          322      322              
  Lines        18523    18523              
  Branches      1055     1055              
===========================================
+ Hits          9131     9134       +3     
+ Misses        9392     9389       -3     
Impacted Files Coverage Δ
...er/util/security/X509CertificateDeserializer.scala 100.00% <ø> (ø)
util-core/src/main/scala/com/twitter/io/Buf.scala 93.27% <0.00%> (ø)
...ore/src/main/scala/com/twitter/util/Duration.scala 85.39% <0.00%> (+0.56%) ⬆️
...in/scala/com/twitter/logging/QueueingHandler.scala 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f15cce...6e0e10f. Read the comment docs.

@jyanJing
Copy link
Contributor

Hi @pjfanning , the change is landed: 47b7acd, thank you for your contribution!

@jyanJing jyanJing closed this Jul 26, 2022
@pjfanning pjfanning deleted the util-security-scala3 branch July 26, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants