Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _importconftest call on pytest>=8 #58

Closed
bluetech opened this issue Jan 13, 2024 · 2 comments · Fixed by #61
Closed

Remove _importconftest call on pytest>=8 #58

bluetech opened this issue Jan 13, 2024 · 2 comments · Fixed by #61

Comments

@bluetech
Copy link

The plugin has some code which accesses some pytest internals to import conftests:

https://github.com/thisch/pytest-sphinx/blob/28f8f4ddf83615da43c138a2360b5246b9fe55b2/src/pytest_sphinx.py#L558-L563

Similar code was present in pytest's builtin doctest plugin, but I've removed it just now: pytest-dev/pytest#11808

The code is no longer necessary on pytest>=8.0.0rc1 (possibly even before, but I'm not sure about that). It'd be great if pytest-sphinx remove it as well, so that it doesn't break if/when pytest breaks these internals.
twmr added a commit that referenced this issue Feb 4, 2024
@twmr
Remove _importconftest call on pytest>=8
9cd2251 
The _importconftest call is no longer needed in the collect method of
the SphinxDoctestModule class according to #58. Therefore, it is
removed in this commit.

Closes #58
@twmr twmr mentioned this issue Feb 4, 2024
Merged
@twmr twmr closed this as completed in #61 Feb 4, 2024
twmr added a commit that referenced this issue Feb 4, 2024
@twmr
Remove _importconftest call on pytest>=8
2d995d2 
The _importconftest call is no longer needed in the collect method of
the SphinxDoctestModule class according to #58. Therefore, it is
removed in this commit.

Closes #58
@twmr
Copy link
Owner

twmr commented Feb 4, 2024

Thx for the info @bluetech. I've just removed it.

@gauteh
Copy link

gauteh commented Mar 20, 2024

Also encountered this. Thanks for the fix. Anxiously awaiting the next release :D

@knutfrode

knutfrode added a commit to poplarShift/opendrift that referenced this issue Mar 20, 2024
@knutfrode
Temporarily disabling pytest-sphinx, awaiting twmr/pytest-sphinx#58
14297c7
twmr added a commit that referenced this issue Apr 1, 2024
@twmr
Release 0.6.1 which includes a fix of #58
7574016 
v0.6.0 accidentally didn't include the fix of #58.
Let's make a new release containing the fix.
twmr added a commit that referenced this issue Apr 1, 2024
@twmr
Release 0.6.1 which includes a fix of #58
a14bca3 
v0.6.0 accidentally didn't include the fix of #58.
Let's make a new release containing the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove _importconftest call on pytest>=8 twmr/pytest-sphinx
3 participants
@gauteh @twmr @bluetech