Up deps, fix vuls, update fixtures #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twolfson
approved these changes
Mar 7, 2021
| @@ -1 +1,2 @@ | |||
| node_modules/ | |||
| yarn.lock | |||
There was a problem hiding this comment.
We don't use Yarn in this repo so shouldn't really need this =/ This seems like it should be in the developer's global .gitignore -- or they should use npm install
Will leave it though I guess, doesn't really hurt anyone, though might confuse them
| @@ -29,8 +29,8 @@ exports._parse = function (argv, _console, callback) { | |||
| DEFAULT_SLEEP_MS) | |||
| .option('--concurrency <concurrency>', | |||
| 'Amount of requests to run in parallel, defaults to ' + DEFAULT_CONCURRENCY, DEFAULT_CONCURRENCY) | |||
| .option('--usermedium <usermedium>', 'Medium where the CSS will be used (e.g. `all` (service default), `print`, `screen`)') | |||
| .option('--profile <profile>', 'CSS profile to use for validation (e.g. `css3svg` (service default), `css21`, `svg`)') | |||
| .option('--usermedium <usermedium>', 'Medium where the CSS will be used (e.g. `all` (service default), `print`, `screen`)') // jscs:disable | |||
There was a problem hiding this comment.
I'm guessing this is for line length, would prefer we silence that rule explicitly. Will update
| @@ -96,7 +99,7 @@ exports._parse = function (argv, _console, callback) { | |||
| } | |||
|
|
|||
| // Continue | |||
| setTimeout(cb, program.sleep); | |||
| setTimeout(cb, opts.delay); | |||
There was a problem hiding this comment.
👍 Nice catch, surprised nobody reported this earlier o_o
| @@ -54,17 +57,17 @@ exports._parse = function (argv, _console, callback) { | |||
| } | |||
|
|
|||
| // Otherwise, perform our validation | |||
| async.eachOfLimit(filepathContentArr, program.concurrency, | |||
| async.eachOfLimit(filepathContentArr, opts.concurrency, | |||
There was a problem hiding this comment.
Was confused why we needed this change -- turns out in Commander@7 they moved it to an inner object to avoid unsafe usage:
|
This has been landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt.delayinstead ofsleepcloses #10