-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that it only works with NSS #33
Conversation
LGTM. @peter0083 could you merge this PR if you feel comfortable with it? |
Solid authentication standard is not ready to use in production back to two years ago (see issue #3 ). The basic auth we implemented was the only way to do authentication at that time (except javascript libs). We actually mentioned the limitation clearly in the document (see the However, it is nice to see the limitation more clearly from the user's perspective. |
@Otto-AA would you like to contribute to |
Thanks for the quick responses!
I guess I'm too good at procrastinating other stuff. So here it is: https://pypi.org/project/solid-oidc-client/ It's based on the work by Rai with solid-flask, but extracted as a library and a lot of refactoring. It works with all pods (ESS, NSS, CSS). Feel free to test it and to integrate it with solid-file-python :) |
|
As mentioned in the forum thread, I think it acts as a client for the Solid OIDC protocol, ie it is not an identity provider, but tries to login a user to an existing IDP through Solid-OIDC. |
Just for information: I created a PR #38 which integrates solid-oidc-client with this library. It's working, but not entirely complete as of the discussion points. |
Looks good to me. Merging this PR. Thank you for your contribution @renyuneyun ! |
Looking at auth.py this project relies on a
/login/password
endpoint and thenssidp.sid
cookie. I think both of these are not standardized and only work with NSS (at least nssidp.sid suggests it is NSS specific).It would make sense to clarify this in the README so users don't get wrong expectations (as in #30).