Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Profile positive and negative volumes are signed to volume, not price #319

Closed
delicateear opened this issue Jun 27, 2021 · 0 comments · Fixed by #320
Closed

Volume Profile positive and negative volumes are signed to volume, not price #319

delicateear opened this issue Jun 27, 2021 · 0 comments · Fixed by #320
Assignees
Labels
bug Something isn't working

Comments

@delicateear
Copy link
Contributor

According to referenced descriptions, Volume Profile should:

  4. Divide the volume into positive volume and negative volume (optional). 

Note that negative volume for a price zone is the sum of volume for all down days in that zone, 
while positive volume is the total of volume for all up days in that price zone.

Instead, vp does:

    signed_volume = signed_series(volume, initial=1)
    pos_volume = signed_volume[signed_volume > 0] * volume
    neg_volume = signed_volume[signed_volume < 0] * -volume

This creates a time series that is signed according to whether the volume increased or decreased on that candle.

Expected behavior

The sign should be determined by the change in price.

We want to see how much volume accompanied rising prices, or falling prices - not how much volume accompanied rising volume and falling volume.

@delicateear delicateear added the bug Something isn't working label Jun 27, 2021
twopirllc added a commit that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants