Make configuration of dynamic asset prefix easier #64
Conversation
index.js
Outdated
| @@ -31,10 +31,10 @@ module.exports = ({ dynamicAssetPrefix = false, ...nextConfig } = {}) => { | |||
| options: { | |||
| limit: nextConfig.inlineImageLimit, | |||
| fallback: require.resolve("file-loader"), | |||
| publicPath: `${nextConfig.assetPrefix || nextConfig.basePath}/_next/static/images/`, | |||
| publicPath: `${(dynamicAssetPrefix ? '' : nextConfig.assetPrefix) || nextConfig.basePath}/_next/static/images/`, | |||
There was a problem hiding this comment.
I think we can remove this nextConfig.basePath from this line. Because I think basePath is for links, not for assets which we're trying to solve with this package. What do you think?
There was a problem hiding this comment.
If no static asset prefix is provided and dynamic asset prefix is disabled we should still fallback to basePath becuase assets will be served under the basePath if it is specified. But if assetPrefix is set or dynamicAssetPrefix is truish then we don't have to take basePath into consideration: in this case static/dynamic assetPrefix should contain the basePath part too. I fix the condition here to represent this.
…set prefixing is disabled.
…d statically generated pages.
|
I've also added the warning message to README about the limitations of dynamic asset prefixes and statically generated pages. |
|
I'm closing it since the PR #65 of @megazazik already contains this change plus he took care of the limitations related to statically generated pages. |
This PR tries to make the usage of Dynamic Asset Prefix feature more clear. From now on if
dynamicAssetPrefixfield innext.config.jsis set totruewe will always produce a dynamic url (based on theassetPrefixextracted from Next.js runtime config) for imported images during transpilation. Unlike before we do not check during transpilation ifassetPrefixfield is defined or not in thenext.config.js.