refactor all charmory. code to armory. namespace #103
Conversation
docs/getting_started.ipynb
Outdated
There was a problem hiding this comment.
@mwartell was this file suppose to be updated like this? It doesn't seem like this is the same file from the master branch
There was a problem hiding this comment.
like maybe this was from another branch's update
There was a problem hiding this comment.
It is accidental You pegged it right, it was an untracked file from #76. I'm removing it in this branch
This was an accidental commit from my working tree of an untracked file. It will rejoin in PR #76 Signed-off-by: matt wartell <matt.wartell@twosixtech.com>
|
|
||
| from armory.model.object_detection.jatic_object_detector import ( | ||
| JaticObjectDetectionModel, | ||
| ) |
There was a problem hiding this comment.
One thing to be wary of when creating package __init__.py files like in this case is now that all the imports in the jatic_object_detector module are required to be installed regardless of whether you're using it or not. I think in this case we're still OK because the actual jatic-toolbox import only occurs during type checking.
This was a pylance generated movement and refactor of library/src/charmory/* to library/src/armory/*
Some text files need to be patched per #102