Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization in support of preparing for mono-repo #40

Merged
merged 24 commits into from
Nov 7, 2023

Conversation

treubig26
Copy link
Collaborator

Moves the armory-library source into the library sub-folder. Additionally, the charmory_examples package is renamed to armory/examples where armory becomes a namespace package.

@treubig26 treubig26 requested a review from mwartell November 6, 2023 14:49
@treubig26 treubig26 marked this pull request as ready for review November 6, 2023 14:49
requirements.txt Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
src_paths = ["library/src"]


[tool.taskipy.tasks]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like taskipy, so fresh, so clean.

Copy link
Contributor

@mwartell mwartell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample replacement code for requirements.txt included.

Copy link
Contributor

@mwartell mwartell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample replacement code for requirements.txt included.

@mwartell mwartell self-requested a review November 7, 2023 17:09
Copy link
Contributor

@mwartell mwartell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substantially correct

if [ -z "$PYTHON" ]; then
echo "Python interpreter not found. Exiting."
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picayune, if you know what python you are calling, might as well echo it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. Are you suggesting something different than the echo on line 22?

@treubig26 treubig26 merged commit 1e74252 into master Nov 7, 2023
18 checks passed
@treubig26 treubig26 deleted the 39-monorepo-reorg branch November 7, 2023 18:25
@treubig26 treubig26 linked an issue Dec 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize repo to support multiple sub-projects
2 participants