set cuda devices for no-docker mode #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use |
|
@dxoigmn thanks for the input, let me know if this revision will satisfy your need. |
LGTM! |
jprokos26
requested changes
May 5, 2023
jprokos26
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this retains the existing behavior when using docker.
For no-docker mode, this sets CUDA_VISIBLE_DEVICES to the list of gpus, if specified, or to -1 if the gpu is not to be used.
It still defaults to using all gpus if use_gpu is True but no gpus are specified.
@christopherwoodall @jprokos26 Do you have any comments about this approach? Any cases I'm overlooking?
Should fix #1923 and #1902. Does not address #1922.