Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes #1928

Merged
merged 5 commits into from
May 5, 2023
Merged

CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes #1928

merged 5 commits into from
May 5, 2023

Conversation

jprokos26
Copy link
Contributor

@jprokos26 jprokos26 commented May 5, 2023 •
edited
Loading

#1890 should utilize this format.

@jprokos26 jprokos26 changed the title CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes (WIP) CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes May 5, 2023
@jprokos26 jprokos26 marked this pull request as draft May 5, 2023 15:19
@jprokos26 jprokos26 changed the title (WIP) CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes CLI flag for getting current branch name for sanity check with venv & pip magic behind the scenes May 5, 2023
@jprokos26 jprokos26 marked this pull request as ready for review May 5, 2023 15:26
christopherwoodall
christopherwoodall approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@christopherwoodall christopherwoodall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jprokos26 jprokos26 merged commit 7597f05 into twosixlabs:develop May 5, 2023
@jprokos26 jprokos26 mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherwoodall christopherwoodall christopherwoodall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprokos26 @christopherwoodall