allow min/max size kwargs for carla multimodal frcnn #1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can get better benign carla performance if you pass
"min_size":960, "max_size":1280
through to the underlying FRCNN model. This works automatically for the unimodal model but requires this minor fix for multimodal.To test/use, set the specified parameters under
"model_kwargs"
in the config.For reference, here are my results without and with these kwargs, using the CARLAAdversarialPatchPyTorch attack.