Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARLA dataset updates #1960

Merged
merged 8 commits into from
Aug 7, 2023
Merged

CARLA dataset updates #1960

merged 8 commits into from
Aug 7, 2023

Conversation

yusong-tan
Copy link
Contributor

Updated green screen coordinates in select CARLA images and videos to fix imperfect patch overlay

@swsuggs swsuggs self-assigned this Jul 17, 2023
@swsuggs swsuggs requested a review from jprokos26 July 26, 2023 16:32
jprokos26
jprokos26 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jprokos26 jprokos26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working for carla_multi_object_tracking_{dev,test} and carla_over_obj_det_dev, each produce a new dataset 1.0.1, 1.0.1, 2.0.1 respectively.

Want to confirm this PR should not have an updated version for carla_over_obj_det_test?

@yusong-tan
Copy link
Contributor Author

Tested working for carla_multi_object_tracking_{dev,test} and carla_over_obj_det_dev, each produce a new dataset 1.0.1, 1.0.1, 2.0.1 respectively.

Want to confirm this PR should not have an updated version for carla_over_obj_det_test?

@jprokos26 correct. carla_multi_object_tracking_{dev,test} and carla_over_obj_det_dev all have corrections to green screen coordinates from their prior versions, whereas carla_over_obj_det_test is the first release for Eval 7 with corrections included.

@swsuggs swsuggs merged commit 0d3f081 into twosixlabs:develop Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprokos26 jprokos26 jprokos26 approved these changes

Assignees

@swsuggs swsuggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yusong-tan @jprokos26 @swsuggs